fix(scully): lint issues and typos#77
Merged
SanderElias merged 1 commit intoscullyio:masterfrom Dec 23, 2019
Merged
Conversation
Contributor
Splaktar
commented
Dec 21, 2019
Splaktar
commented
- remove some unused imports
- shorten some import paths
- fix variables with the same name in the same scope
SanderElias
reviewed
Dec 21, 2019
SanderElias
requested changes
Dec 21, 2019
Contributor
SanderElias
left a comment
SanderElias
left a comment
There was a problem hiding this comment.
Thanks @Splaktar.
I like the cleanup, with the exception listed.
We can merge this after the change.
Splaktar
force-pushed
the
fix-typos-lint
branch
from
52e0b20 to
629875f
Compare
SanderElias
reviewed
Dec 22, 2019
SanderElias
reviewed
Dec 22, 2019
Contributor
SanderElias
left a comment
SanderElias
left a comment
There was a problem hiding this comment.
the getSctript function now isn't returning the string anymore?
Contributor
Author
|
Doh. Sorry. Will update again soon. |
- remove some unused imports - shorten some import paths - fix variables with the same name in the same scope
Splaktar
force-pushed
the
fix-typos-lint
branch
from
629875f to
fc06e86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.